Re: [PATCH v2] mmc-utils: Merge the lsmmc tool into mmc-utils

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3 February 2016 at 06:04, Sebastian Rasmussen <sebras@xxxxxxxxx> wrote:
>> The original code is created by Sebastian Rasmussen and still lives in
>> private git.
>
> Actually the company at which I developed the code has since been
> dissolved so I believe that the only place where this code currently
> lives is as an attachment in the mail archive of linux-mmc.

Got it.

>
>> It need to be merged into mmc-utils repository, which is
>> convenient for testing MMC device from userspace.
>
> I fully agree. Though maybe the subcommands csd/cid/scr read all should be
> brought to conform to the other subcommands in terms of using e.g.
> CHECK() and checking for errors using perror(). Basically I would want
> the new subcommands to be indistiguishable from the existing commands.
> Even if I developed the code at my previous employer it just looks
> nasty if it is tacked on without being a proper part of the existing
> code. :)
>
> Also I'm a bit wary of that lsmmc.ids database as it is currently not
> installed if you do "make install" as it probably should be. Maybe it
> is better to hardcode this internally in the program and avoid having
> to deal with installation?

OK. So it can remove the '-f' parameter.

>
> Either way, I'm happy to continue working getting this into mmc-utils.

That's great. I think you can continue doing it. Thanks a lot.

>
>  / Sebastian



-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux