On 3 February 2016 at 05:39, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Tue, Feb 2, 2016 at 9:21 AM, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote: > >> The lsmmc tools contains an extensive parser of the CID, CSD, SCR, EXT_CSD >> registers from userspace. The utility works as-is and uses sysfs to read >> the register values. >> >> The original code is created by Sebastian Rasmussen and still lives in >> private git. It need to be merged into mmc-utils repository, which is >> convenient for testing MMC device from userspace. >> >> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx> > > Nitpicky formalia: > > The SoB-chain should represent the delivery path of the code, so I think > it should be: > > Signed-off-by: Sebastian Rasmussen <sebras@xxxxxxxxx> > Signed-off-by: Chris Ball <chris@xxxxxxxxxx> > Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx> > > ..and then when Ulf merges it it get his SoB too. > > Then the Author: has no strong rule by usually should > represent who wrote the majority of the code, so unless you've changes > more than 50% of the code, consider > git commit --amend --author="Sebastian Rasmussen <sebras@xxxxxxxxx>" > for this commit. > > I usually don't care a lot about the latter but since it's a big and initial > commit I think it matters. If it's too diverse authors and unclear > contributor distribution, a mailing list can be used as author, c.f. > commit a8c21a5451d831e67b7a6fb910f9ca8bc7b43554 OK, make sense. Thanks. > > Thanks for working on this! > > Yours, > Linus Walleij -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
