On 26 January 2016 at 11:42, Jisheng Zhang <jszhang@xxxxxxxxxxx> wrote:
> The device power usage counter is increased by pm_runtime_get_noresume
> but isn't decreased in err_add_host error path.
>
> Fix this issue by calling pm_runtime_put_noidle() in the error path to
> restore the device's power usage counter.
>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
> Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support)
> ---
> drivers/mmc/host/sdhci-of-at91.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index 7db7163..3bf6f31 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -210,7 +210,7 @@ static int sdhci_at91_probe(struct platform_device *pdev)
>
> pm_runtime_disable:
> pm_runtime_disable(&pdev->dev);
> - pm_runtime_set_suspended(&pdev->dev);
What's the reason you want to remove the call to
pm_runtime_set_suspended()? I think it could stay.
> + pm_runtime_put_noidle(&pdev->dev);
> clocks_disable_unprepare:
> clk_disable_unprepare(priv->gck);
> clk_disable_unprepare(priv->mainck);
> --
> 2.7.0
>
Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
