On Monday 25 January 2016 12:56:25 Shawn Lin wrote: > On 2016/1/25 12:14, Jaehoon Chung wrote: > > Hi, Shawn. > > > > On 01/25/2016 10:13 AM, Shawn Lin wrote: > >> This patch remove repetitive clear interrupt while > >> probing dw_mmc. > > > > Could you explain to me more? > > yes, it's a trivial improvement. > > dw_mci_probe clear interrupt and disable all interrupt firstly. > Then commit 2da1d7f2 add a new clear-interrupt operation before > enable some interrupt. I can't see any reason to clear it twice > here. No any side effect I had found in my test pattern without this > . May I miss some important case? > The explanation should go into the patch description to explain why it is done. The one sentence "This patch remove repetitive clear interrupt while probing dw_mmc" that you wrote instead can be removed, it just repeats the patch subject. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
