Hi, Carlo In 9faac7b95, tuning for DDR50 is enabled in mmc_sd_init_uhs_card(), so only SD card is affected. This is based on the SD spec version 3.01. mmc_sdio_init_uhs_card() is untouched. I don't know who add the code into mmc_sdio_init_uhs_card() and you may have a check on your side. -----Original Message----- From: carlo.caione@xxxxxxxxx [mailto:carlo.caione@xxxxxxxxx] On Behalf Of Carlo Caione Sent: 2015年12月13日 7:52 To: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Cc: Barry Song <21cnbao@xxxxxxxxx>; Yang, York <weijuny@xxxxxxxxxxxxxxxx>; linux-mmc <linux-mmc@xxxxxxxxxxxxxxx>; DL-SHA-WorkGroupLinux <workgroup.linux@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Song, Barry <baohuas@xxxxxxxxxxxxxxxx> Subject: Re: [PATCH 1/2] mmc: core: enable CMD19 tuning for DDR50 mode On Wed, Sep 23, 2015 at 9:25 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > [...] > >>> >>> Also, I was giving this a second thought... >>> >>> What happens with the SD 3.0 card when it *doesn't* support CMD19. >>> Will it still be functional afterwards or will it move from >>> "transfer state" to another not known state? >> >> uffe, i am not the expert of this issue but weijun is. weijun told >> that for the cards who don't support cmd19, it will take it as >> illegal command and not response it. and it also sets illegal command >> error in registers. >> but the card status is still functional and doesn't cause unknown state. >> >> so maybe we can just ignore the err of tuning, and use the second >> patch with the refine you mentioned? > > Sure, let's do that. Please send a v2 of the patchset then. Replying here since I'm not subscribed to linux-mmc. Commit 9faac7b95 "mmc: sdhci: enable tuning for DDR50" actually breaks WiFi on SDIO at least for the ASUS X205TA. I tried to ignore the error from the tuning also for the SDIO card patching mmc_sdio_init_uhs_card() in drivers/mmc/core/sdio.c but I end up with the error "Controller never released inhibit bit(s)". At least in my case CMD19 shouldn't be issued at all to have the SDIO card working. Any suggestion how to approach this problem? -- Carlo Caione To report this email as spam click https://www.mailcontrol.com/sr/t!EO05MqfQ7GX2PQPOmvUkWM85sEKD4+jZQCQMWcEF+Ktu75GnJjKIuILC13YpF6Ld90r0YXMUaNc!rJiVGaJg== . ��.n��������+%������w��{.n�����{��i��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
