On Tue, 2015-12-08 at 14:49 +0100, Ulf Hansson wrote: > On 27 November 2015 at 04:20, Yangbo Lu <yangbo.lu@xxxxxxxxxxxxx> wrote: > > The sdhci-of-esdhc driver needs the syscon support to do > > regmap and access the global utilities registers. So we > > select MFD_SYSCON for MMC_SDHCI_OF_ESDHC here. > > > > Signed-off-by: Yangbo Lu <yangbo.lu@xxxxxxxxxxxxx> > > --- > > Changes for v2: > > - None > > Changes for v3: > > - Added this patch > > --- > > drivers/mmc/host/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > > index 1526b8a..4fb88ba 100644 > > --- a/drivers/mmc/host/Kconfig > > +++ b/drivers/mmc/host/Kconfig > > @@ -142,6 +142,7 @@ config MMC_SDHCI_OF_ESDHC > > depends on MMC_SDHCI_PLTFM > > depends on PPC || ARCH_MXC || ARCH_LAYERSCAPE > > select MMC_SDHCI_IO_ACCESSORS > > + select MFD_SYSCON > > Perhaps "depends on" is better to use here. Plenty of other thing select MFD_SYSCON, and MFD_SYSCON doesn't have any dependencies. Why would you torment a user by making them somehow guess (or dig around to find out) that they need to enable MFD_SYSCON before seeing a random other driver appear? -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
