On Fri, Oct 09, 2015 at 03:03:53AM +0200, Marcin Wojtas wrote: > The newest revisions of A388-GP (v1.5 and higher) support only > DAT3-based card detection. Revisions < v1.5 based on GPIO detection > via I2C expander, but this solution is supposed to be deprecated on > new boards. In order to satisfy all type of hardware this commit > changes card detection to use software polling mechanism. Hi Marcin Thanks for going with broken-cd and not introducing a regression for older boards. As others have said, a comment would be good, but otherwise: Acked-by: Andrew Lunn <andrew@xxxxxxx> Thanks Andrew > > Signed-off-by: Marcin Wojtas <mw@xxxxxxxxxxxx> > --- > arch/arm/boot/dts/armada-388-gp.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts > index 391dea9..403a86b 100644 > --- a/arch/arm/boot/dts/armada-388-gp.dts > +++ b/arch/arm/boot/dts/armada-388-gp.dts > @@ -213,8 +213,8 @@ > sdhci@d8000 { > pinctrl-names = "default"; > pinctrl-0 = <&sdhci_pins>; > - cd-gpios = <&expander0 5 GPIO_ACTIVE_LOW>; > no-1-8-v; > + broken-cd; > wp-inverted; > bus-width = <8>; > status = "okay"; > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html