On Tue, 2015-09-22 at 03:56 -0500, Lu Yangbo-B47093 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 02, 2015 8:24 AM > > To: Lu Yangbo-B47093 > > Cc: linux-mmc@xxxxxxxxxxxxxxx; ulf.hansson@xxxxxxxxxx > > Subject: Re: [v2, 2/3] mmc: sdhci-of-esdhc: get SOC version and revision > > from GUTS_SVR > > > > On Thu, 2015-08-27 at 17:29 +0800, Yangbo Lu wrote: > > > @@ -24,6 +25,16 @@ > > > > > > #define VENDOR_V_22 0x12 > > > #define VENDOR_V_23 0x13 > > > + > > > +/* Global Utility Registers */ > > > +#define GUTS_SVR 0xa4 /* System Version Register */ > > > +/* SOC version definition */ > > > +#define SVR_T4240 0x824000 > > > > Please do not redefine this stuff in each driver that needs to reference > > it. > > > > -Scott > > [Lu Yangbo-B47093] SOC version definition like SVR_T4240 is in > arch/powerpc/include/asm/mpc85xx.h > It's only for PPC and Uffe thought it's not good to introduce non generic > header file. > Is there any suggestion about this? Either use ifdefs or move it to include/linux/fsl-svr.h. It's not only for PPC. Our ARM QorIQ chips also have SVR (accessible only through MMIO). -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
