Re: [PATCH 3/3] mmc: usdhi6rol0: fix ack register write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19 August 2015 at 15:41, Rabin Vincent <rabin.vincent@xxxxxxxx> wrote:
> The intent appears to be to clear only the bits which are set in status
> (by setting them to zero in the ack write), like in the other interrupt
> handlers, and not to always clear everything (by always writing zero).
> Use the correct not operator.
>
> Signed-off-by: Rabin Vincent <rabin.vincent@xxxxxxxx>

Thanks, applied for next!

Kind regards
Uffe


> ---
>  drivers/mmc/host/usdhi6rol0.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c
> index 4188e84e..b505cbc2 100644
> --- a/drivers/mmc/host/usdhi6rol0.c
> +++ b/drivers/mmc/host/usdhi6rol0.c
> @@ -1611,7 +1611,7 @@ static irqreturn_t usdhi6_cd(int irq, void *dev_id)
>                 return IRQ_NONE;
>
>         /* Ack */
> -       usdhi6_write(host, USDHI6_SD_INFO1, !status);
> +       usdhi6_write(host, USDHI6_SD_INFO1, ~status);
>
>         if (!work_pending(&mmc->detect.work) &&
>             (((status & USDHI6_SD_INFO1_CARD_INSERT) &&
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux