On 25 August 2015 at 12:27, Lu Y.B. <yangbo.lu@xxxxxxxxxxxxx> wrote: > Please see my comments below. > >> -----Original Message----- >> From: Li Yang-Leo-R58472 >> Sent: Tuesday, August 25, 2015 6:56 AM >> To: Lu Yangbo-B47093 >> Cc: linux-mmc@xxxxxxxxxxxxxxx; ulf.hansson@xxxxxxxxxx; >> devicetree@xxxxxxxxxxxxxxx >> Subject: Re: [v4,1/6] mmc: dt: add DT binding for big endian controller >> >> > Add specification of 'big-endian' property. if the controller is big >> > endian mode, specify this property in device tree node. >> > The default endian mode is little endian. >> >> You shouldn't make the default endian mode to be little endian because in >> the original binding without this new property we are actually expecting >> big-endian hardware. Making little-endian the default is breaking the >> compatibility with the original binding. >> >> Regards, >> Leo > > Thanks a lot, Leo. > > Hi Uffe, > > Since it doesn't make sense to extend the common MMC DT parser, mmc_of_parse(), to fetch the endian mode, > I'd like to move endian fetching code and all LE/BE accessors definition to eSDHC driver. Please them parts of the sdhci generic code, as library functions. > > And the default endian would be set to big-endian again for eSDHC. That's okay, just make sure it's properly documented in the DT binding doc for esdhc. > > Use function pointers that are assigned in probe according endian mode to avoid checking endian every time. > I'd also like to separate eMMC DDR mode patch from this patchset. Would send it with other UHS-1 speed mode patches together. Makes perfect sense! So in your sdhci host specific driver, you will find out the endian type and make use of the corresponding library functions gets assigned in the host ops which is provided to sdhci_pltfm_init. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
