On Monday 17 August 2015 14:17:25 Geert Uytterhoeven wrote: > >> This will break out-of-tree boards at compile-time though. Given the limited > >> number of wired up DMA channels under arch/sh/, they may actually be > >> more in use out-of-tree than in-tree? > >> > >> Alternatively, perhaps we should just drop pdata DMA configuration from > >> some drivers? > > > > I think that would be helpful, but it would not work for this driver as > > long as we keep arch/sh/boards/board-sh7757lcr.c in the kernel. > > No, not for this driver. > > But there are several drivers (spi-rspi, spi-sh-msiof, sh-sci, sh_flctl) that > have .slave*id* fields in platform data, but no platform code ever sets them. > Despite platform code that fills in SHDMA_SLAVE_* values in sh_dmae_chan. > These don't work anyway, and I don't think anyone is interested in fixing that. Right, removing pdata support for those would be a useful cleanup. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html