Re: [PATCH 1/3] mmc: dw_mmc: fix the wrong condition checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jaehoon

On Thu, Aug 6, 2015 at 12:53 PM, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote:
>
> When num-slots is lower than 1, it's right that should be returned -ENODEV.
>
make sense.

> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
Tested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> ---
>  drivers/mmc/host/dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 3c0e199..de88e64 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2760,7 +2760,7 @@ int dw_mci_probe(struct dw_mci *host)
>                 }
>         }
>
> -       if (host->pdata->num_slots > 1) {
> +       if (host->pdata->num_slots < 1) {
>                 dev_err(host->dev,
>                         "Platform data must supply num_slots.\n");
>                 return -ENODEV;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html




-- 
Regards,
Alim
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux