Re: [PATCH v1 1/1] mmc: atmel-mci: allow DMA transfers for AVR32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

Your patch does a bit more than reverting commit ecb89f2f5f3e. I will
split it in order to see well which previous patches have been reverted.

On Mon, Jul 27, 2015 at 05:45:34PM +0300, Andy Shevchenko wrote:
> On Mon, 2015-07-27 at 14:24 +0200, Arnd Bergmann wrote:
> > On Monday 27 July 2015 14:53:30 you wrote:
> > > The commit ecb89f2f5f3e (mmc: atmel-mci: remove compat for non DT 
> > > board when
> > > requesting dma chan) removes compat transfer which breaks DMA
> > > support for ATNGW100. This patch returns back that functionality.
> > > 
> > > Cc: Ludovic Desroches <ludovic.desroches@xxxxxxxxx>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > 
> > 
> > How about moving that filter function into arch/avr32 to make the
> > mmc driver independent of the underlying dma engine implementation
> > at the same time?

It would be great to not keep code which becomes architecture dependant.
If we can move the filter function somewhere in arch/avr32, we will have
to revert commit fda1b26 and use dma_request_slave_channel_compat.

I had a look to the arch/avr32 directory but I don't know where to put
this kind of stuff.

> 
> It might be a good idea, but I'm neither an expert in avr32 nor have
> time right now to do this better. Consider this a bug report with a
> work around which works for me. I can test any better solution someone
> proposes.

Regards

Ludovic
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux