Re: [RFC PATCH] mmc: Kconfig: Add dependency on GPIOLIB for Arasan driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michal,

comment in line

On 15-07-24 06:53 AM, Michal Simek wrote:
The patch "mmc: sdhci-of-arasan: Call OF parsing for MMC"
(sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) introduce new
dependency on GPIOLIB which calls mmc_of_parse() ->
mmc_gpiod_request_cd() (slot-gpio.c) which calls devm_gpiod_get_index()
which returns -ENOSYS.

Error log:
sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258)
sdhci-arasan: probe of ff160000.sdhci failed with error -38

Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
---

This problem is probably in all others drivers.
This is one way how this can be solved.
Maybe better way is to block return value for cd and wp.

It appears there is gpio code in sdhci.c as well.  This uses slot-gpio.

Perhaps a depends on needs to be added to MMC_SDHCI instead?


---
  drivers/mmc/host/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index fd9a58e216a5..4b5854759cfc 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -120,6 +120,7 @@ config MMC_SDHCI_PLTFM
  config MMC_SDHCI_OF_ARASAN
  	tristate "SDHCI OF support for the Arasan SDHCI controllers"
  	depends on MMC_SDHCI_PLTFM
+	depends on GPIOLIB
  	depends on OF
  	help
  	  This selects the Arasan Secure Digital Host Controller Interface


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux