2015-06-15 11:55 GMT+02:00 Ulf Hansson <ulf.hansson@xxxxxxxxxx>: > On 12 June 2015 at 11:31, Mirza Krak <mirza.krak@xxxxxxxxxxxxxxxx> wrote: >> From: Mirza Krak <mirza.krak@xxxxxxxxxxxxxxxx> >> >> Add support for current states of pinctrl, which are "default", "idle" >> and "sleep". >> >> The "default" pinctrl state is set by Drivers core before >> calling the driver's probe, hence we do not need a initial call to >> "default" state. >> >> Signed-off-by: Mirza Krak <mirza.krak@xxxxxxxxxxxxxxxx> > > Hi Mirza, > > This looks okay to me, but it seems like it needs a re-base towards my > mmc next branch. > > Kind regards > Uffe Looked at the mmc next branch. I see that the suspend/resume methods of sdhci-esdhci-imx have been removed and the generic sdhci_pltfm_suspend/resume are used. So I am unsure if it is OK to set the pinctl "sleep" state in sdhci_pltfm_suspend or is there a better location for this. I am thinking sdhci_suspend_host would be good location, but then the change will effect a lot more drivers. Maybe a good thing? Regarding the "idle" state of pinctrl, this could also be moved to sdhci_runtime_suspend_host, affecting more drivers. Again a good thing? -- Med Vänliga Hälsningar / Best Regards ******************************************************************* Mirza Krak Host Mobility AB mirza.krak@xxxxxxxxxxxxxxxx Anders Personsgatan 12, 416 64 Göteborg Sweden http://www.hostmobility.com Direct: +46 31 31 32 704 Phone: +46 31 31 32 700 Fax: +46 31 80 67 51 Mobile: +46 730 28 06 22 ******************************************************************* -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
