On Wed, May 6, 2015 at 1:11 AM, Rob Herring <robherring2@xxxxxxxxx> wrote: > On Tue, May 5, 2015 at 4:17 AM, Suman Tripathi <stripathi@xxxxxxx> wrote: >> This patch adds the arasan sdhc nodes to reuse the of-arasan >> driver for APM X-Gene SoC. >> >> Signed-off-by: Suman Tripathi <stripathi@xxxxxxx> >> --- >> arch/arm64/boot/dts/apm/apm-mustang.dts | 4 +++ >> arch/arm64/boot/dts/apm/apm-storm.dtsi | 44 +++++++++++++++++++++++++++++++++ >> 2 files changed, 48 insertions(+) > > [...] > >> @@ -533,6 +567,16 @@ >> interrupts = <0x0 0x4f 0x4>; >> }; >> >> + sdhc0: sdhc@1c000000 { >> + device_type = "sdhc"; > > device_type generally should not be used (there are a few exceptions). Okay !! > >> + compatible = "arasan,sdhci-4.9a"; > > If you ever have an integration or xgene specific problem, you need a > chip specific compatible. No it;s a IP level problem. If it's a SoC level then probably we cann't reuse the existing arasan version. If anything happens in future we might need our own version. > > Rob -- Thanks, with regards, Suman Tripathi -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html