On 30 April 2015 at 18:28, Jae hoon Chung <jh80.chung@xxxxxxxxx> wrote: > > > 2015-04-30 17:37 GMT+09:00 zhangfei <zhangfei.gao@xxxxxxxxxx>: >> >> >> >> On 04/30/2015 04:01 PM, Jaehoon Chung wrote: >>> >>> Hi. >>> >>> On 04/29/2015 10:31 PM, Zhangfei Gao wrote: >>>> >>>> Set 0 to des1 in 32bit case. >>>> Otherwise the random value of des1 will be used in >>>> dw_mci_translate_sglist: IDMAC_64ADDR_SET_BUFFER1_SIZE(desc, length) >>> >>> >>> I'm not understanding this comment. >>> how does it use the IDMAC_64ADDR_SET_BUFFER1_SIZE(desc, length)? >> >> >> p->des1 contains random value, coming from dmam_alloc_coherent in >> dw_mci_init_dma >> >> In dw_mci_translate_sglist -> IDMAC_SET_BUFFER1_SIZE(desc, length); >> #define IDMAC_SET_BUFFER1_SIZE(d, s) \ >> ((d)->des1 = ((d)->des1 & 0x03ffe000) | ((s) & 0x1fff)) >> > I think you need to change the commit message > (IDMAC_SET_BUFFER1_SIZE instead of IDMAC_64ADDR_SET_BUFFER1_SIZE. > > You mentioned about desc1, but IDMAC_64ADDR_SET_BUFFER1_SIZE assign to > desc2. Yes, made mistake, will change the log. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
