On Tue, 3 Mar 2015 13:28:12 +0100 Andreas Fenkart <afenkart@xxxxxxxxx> wrote: > These patches are trying to clean up the cover/card detect logic. > > Mobile phones (some) have no card detect pin, but > can detect if the cover is removed. The purpose is the > same; detect if card is being added/removed, but the > details differ. > When the cover is removed, it does not mean the card is > gone. But it might, since it is accessible now. It's like > a warning. All the driver does is to limit write access to > the card, see protect_card flag. In contrast, card detect > notifies us after the fact, e.g. card is gone, card is > inserted. > > While cover detect is only used by one platform (rx51), it > complicates the card detect logic. By separating the code > paths they both become easier to understand and maintain > > Patches have been tested by reverting: 95bebb5696ab > 'mmc: omap_hsmmc: use mmc_of_parse to parse common mmc configuration' > otherwise gpio detection is handled by mmc_of_parse Wouldn't it make more sense to put this core in mmc/core rather than in just one host controller? That way it would be available to all hosts, and you wouldn't need to revert that patch. NeilBrown
Attachment:
pgpFYm7UMGAGu.pgp
Description: OpenPGP digital signature
