On 27 January 2015 at 15:34, Jean Delvare <jdelvare@xxxxxxx> wrote: > Hi Ulf, > > Le Tuesday 27 January 2015 à 15:06 +0100, Ulf Hansson a écrit : >> On 26 January 2015 at 11:23, Jean Delvare <jdelvare@xxxxxxx> wrote: >> > I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are >> > only needed on the MMP architecture. So add a hardware dependency on >> > ARCH_MMP, so that other users don't get to build useless drivers. >> >> I would rather see the default option to be N. >> Thus those configurations that needs this driver will have to select it. > > This is a different question. The purpose of my patch is that people > configuring kernels for systems which just can't have these controllers, > are not asked about this driver at all. Changing the default to N would > not achieve that. For those SOC that want these drivers, they should be able to select them from their defconfigs. So it will be an opt-in instead of opt-out policy, which I prefer. It also follows the other Kconfig options for mmc drivers. Kind regards Uffe > > That being said, feel free to change the default to N if you want, but > to me (who knows nothing about MMP architecture and not much about MMC) > the current default values look sane. > > Thanks, > Jean > >> > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> >> > Cc: Chris Ball <chris@xxxxxxxxxx> >> > Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx> >> > Cc: Eric Miao <eric.y.miao@xxxxxxxxx> >> > Acked-by: Haojian Zhuang <haojian.zhuang@xxxxxxxxx> >> > --- >> > This patch was already sent on: >> > * 2014-04-23 >> > * 2014-06-16 >> > >> > drivers/mmc/host/Kconfig | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > --- linux-3.19-rc6.orig/drivers/mmc/host/Kconfig 2015-01-26 10:30:56.472182636 +0100 >> > +++ linux-3.19-rc6/drivers/mmc/host/Kconfig 2015-01-26 11:13:33.669863314 +0100 >> > @@ -228,6 +228,7 @@ config MMC_SDHCI_PXAV3 >> > tristate "Marvell MMP2 SD Host Controller support (PXAV3)" >> > depends on CLKDEV_LOOKUP >> > depends on MMC_SDHCI_PLTFM >> > + depends on ARCH_MMP || COMPILE_TEST >> > default CPU_MMP2 >> > help >> > This selects the Marvell(R) PXAV3 SD Host Controller. >> > @@ -240,6 +241,7 @@ config MMC_SDHCI_PXAV2 >> > tristate "Marvell PXA9XX SD Host Controller support (PXAV2)" >> > depends on CLKDEV_LOOKUP >> > depends on MMC_SDHCI_PLTFM >> > + depends on ARCH_MMP || COMPILE_TEST >> > default CPU_PXA910 >> > help >> > This selects the Marvell(R) PXAV2 SD Host Controller. >> > >> > >> > -- >> > Jean Delvare >> > SUSE L3 Support > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
