Re: [PATCH] mmc: block: Remove unnecessary temporary variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21 January 2015 at 15:56, Tobias Klauser <tklauser@xxxxxxxxxx> wrote:
> Directly return the result of mmc_blk_alloc_req() instead of assigning
> and returning the variable md.
>
> Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>

Thanks! Applied for next.

Kind regards
Uffe

> ---
>  drivers/mmc/card/block.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 4409d79..2c98b72 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -2193,7 +2193,6 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
>  static struct mmc_blk_data *mmc_blk_alloc(struct mmc_card *card)
>  {
>         sector_t size;
> -       struct mmc_blk_data *md;
>
>         if (!mmc_card_sd(card) && mmc_card_blockaddr(card)) {
>                 /*
> @@ -2209,9 +2208,8 @@ static struct mmc_blk_data *mmc_blk_alloc(struct mmc_card *card)
>                 size = card->csd.capacity << (card->csd.read_blkbits - 9);
>         }
>
> -       md = mmc_blk_alloc_req(card, &card->dev, size, false, NULL,
> +       return mmc_blk_alloc_req(card, &card->dev, size, false, NULL,
>                                         MMC_BLK_DATA_AREA_MAIN);
> -       return md;
>  }
>
>  static int mmc_blk_alloc_part(struct mmc_card *card,
> --
> 2.2.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux