+ linux-mmc On 14 January 2015 at 07:24, Tim Kryger <tim.kryger@xxxxxxxxx> wrote: > Host controllers lacking the required internal vmmc regulator may still > follow the spec with regard to the LSB of SDHCI_POWER_CONTROL. Set the > SDHCI_POWER_ON bit when vmmc is enabled to encourage the controller to > to drive CMD, DAT, SDCLK. > > This fixes a regression observed on some Qualcomm and Nvidia boards > caused by 5222161 mmc: sdhci: Improve external VDD regulator support. > > Signed-off-by: Tim Kryger <tim.kryger@xxxxxxxxx> > Tested-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> Thanks! Applied for fixes. I noticed this wasn't posted to linux-mmc. I am anyway picking it up as this change has already been discussed and tested, see: https://lkml.org/lkml/2014/11/3/1029 Kind regards Uffe > --- > drivers/mmc/host/sdhci.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index ada1a3e..59a328a 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1239,6 +1239,12 @@ static void sdhci_set_power(struct sdhci_host *host, unsigned char mode, > spin_unlock_irq(&host->lock); > mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd); > spin_lock_irq(&host->lock); > + > + if (mode != MMC_POWER_OFF) > + sdhci_writeb(host, SDHCI_POWER_ON, SDHCI_POWER_CONTROL); > + else > + sdhci_writeb(host, 0, SDHCI_POWER_CONTROL); > + > return; > } > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
