Hi Ulf, again > > > void tmio_mmc_abort_dma(struct tmio_mmc_host *host) > > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > > > index 5738817..6788f9b 100644 > > > --- a/include/linux/mfd/tmio.h > > > +++ b/include/linux/mfd/tmio.h > > > @@ -111,6 +111,7 @@ void tmio_core_mmc_pwr(void __iomem *cnf, int shift, int state); > > > void tmio_core_mmc_clk_div(void __iomem *cnf, int shift, int state); > > > > > > struct dma_chan; > > > +struct tmio_mmc_host; > > > > > > struct tmio_mmc_dma { > > > void *chan_priv_tx; > > > @@ -120,10 +121,9 @@ struct tmio_mmc_dma { > > > int alignment_shift; > > > dma_addr_t dma_rx_offset; > > > bool (*filter)(struct dma_chan *chan, void *arg); > > > + void (*enable)(struct tmio_mmc_host *host, bool enable); > > > > Before we decide to add more callbacks to this struct, can we please > > try to move the mmc specific parts into the mmc tmio specific header? > > drivers/mmc/host/tmio_mmc.h. > > > > For example the tmio_mmc_dma can be moved there. Hmm.... tmio_mmc_dma is used from tmio_mmc_data. And, tmio_mmc_data is used from drivers/mfd/xxx.c It seems impossible to move it. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html