Re: [PATCH] mmc: toshsd: Fix unbalanced locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11 December 2014 at 04:10, Axel Lin <axel.lin@xxxxxxxxxx> wrote:
> Fix returning IRQ_HANDLED with spin_lock held.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>

Thanks! Queued for 3.20.

Kind regards
Uffe

> ---
>  drivers/mmc/host/toshsd.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/toshsd.c b/drivers/mmc/host/toshsd.c
> index 4666262..a5aa539 100644
> --- a/drivers/mmc/host/toshsd.c
> +++ b/drivers/mmc/host/toshsd.c
> @@ -176,7 +176,8 @@ static irqreturn_t toshsd_thread_irq(int irq, void *dev_id)
>         spin_lock_irqsave(&host->lock, flags);
>
>         if (!sg_miter_next(sg_miter))
> -               return IRQ_HANDLED;
> +               goto done;
> +
>         buf = sg_miter->addr;
>
>         /* Ensure we dont read more than one block. The chip will interrupt us
> @@ -198,6 +199,7 @@ static irqreturn_t toshsd_thread_irq(int irq, void *dev_id)
>         sg_miter->consumed = count;
>         sg_miter_stop(sg_miter);
>
> +done:
>         spin_unlock_irqrestore(&host->lock, flags);
>
>         return IRQ_HANDLED;
> --
> 1.9.1
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux