On Mon, 08 Dec 2014, 敬锐 wrote: > > On 12/08/2014 04:49 PM, Lee Jones wrote: > >> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h > >> >index 74346d5..9234449 100644 > >> >--- a/include/linux/mfd/rtsx_pci.h > >> >+++ b/include/linux/mfd/rtsx_pci.h > >> >@@ -558,6 +558,7 @@ > >> > #define SD_SAMPLE_POINT_CTL 0xFDA7 > >> > #define SD_PUSH_POINT_CTL 0xFDA8 > >> > #define SD_CMD0 0xFDA9 > >> >+#define SD_CMD_START 0x40 > > This is a different format at the others in the group on two counts; > > firstly you have 3 whitespace characters after the #define and > > secondly all of the other hex digits in the set are 4 a breast. > > Please add the leading zeros to conform to this format. > > > Hi lee, > > This format is more readable, add 2 space means this value is > in groups under register SD_CMD0, and each register value is u8 type, > so use 2 hex digits is right. > > The original file make register address and its related value separated, > and group register together. > > But I like to write register address and value together, > add 2 space for value to indicate this value is related to above register. > > If we add new address/value, I recommend write register define format as > below: > > #define REGISTER addr > #define REG_VAL1 val1 > #define REG_VAL2 val2 Okay, I see that there are other occurrences using this format in that file. Please consider converting the entire file into this format. I don't mind it either way, but it looks odd if they are mixed. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
