On Fri, Nov 28, 2014 at 03:08:04PM +0100, Ludovic Desroches wrote: > Using __init/__exit attributes can cause several breakages so remove > them. I've really no idea why people jump overboard with these things - it seems people go from one extreme to the other (adding lots of __init / __exit annotations everywhere to removing them all), but: > @@ -2573,12 +2573,12 @@ static struct platform_driver atmci_driver = { > }, > }; > > -static int __init atmci_init(void) > +static int atmci_init(void) > { > return platform_driver_probe(&atmci_driver, atmci_probe); > } > > -static void __exit atmci_exit(void) > +static void atmci_exit(void) > { > platform_driver_unregister(&atmci_driver); > } These last two are totally fine to leave there. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html