On Friday 28 November 2014 09:16:24 Peter Ujfalusi wrote: > On 11/27/2014 11:52 PM, Arnd Bergmann wrote: > > On Thursday 27 November 2014 20:46:12 Peter Ujfalusi wrote: > >> > >> I see. With this series I did not planed to fix all edma related issues, just > >> as a start clean up the related header files. I would rather not add fixes to > >> mmc, spi, etc drivers since while you have valid point it is not in the scope > >> of this series. > >> Can we do the changes you are suggesting in an incremental manner? > > > > Sure, but I'd leave the existing filter function declaration alone then > > and not move it, since we wouldn't want to keep it in the long run. > > but if you want to reference the filter function (which is in > drivers/dma/edma.c) in arch/arm/mach-davinci/ directory, we will need it. > Don't we? Yes, unless you move the definition of the filter function into arch/arm/common/edma.c or arch/arm/mach-davinci/devices.c, but that would require other changes. > If I leave the header as it is, then how would we clean up the edma headers? I > would not put the API definitions for the arch code into the same file as we > have the filter definition. Ok, just go ahead with your current patch then, we can always follow up. The most important cleanup for edma is elsewhere anyway, so once the asoc drivers can use the dmaengine interface, this should be easier. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
