On 10/30/2014 12:36 AM, Scott Branden wrote: > Make the shift calculations consistent rather than having different > implementations to calculate the same thing. > diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c > +#define REG_OFFSET_IN_BITS(reg) ((reg) << 3 & 0x18) This should really be the following so people don't have to memorize operator precedence: #define REG_OFFSET_IN_BITS(reg) (((reg) << 3) & 0x18) (I've been bit by people mis-remembering precedence in very similar code...) -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
