Re: [PATCH 3/4] mmc: core: make hw_reset generic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2014-11-03 10:20 GMT+01:00 Adrian Hunter <adrian.hunter@xxxxxxxxx>:
> On 24/10/14 15:46, Johan Rudholm wrote:
>> Move the (e)MMC specific hw_reset code from core.c into mmc.c and call
>> it from the new bus_ops member power_reset. This also lets us add code
>
> power_reset is not a good name because it does not necessarily have
> anything to do with power.  I am not sure why you don't stick with
> hw_reset.
>
>> for reseting SD cards as well.
>>
>> Rename the mmc_hw_reset* functions into mmc_reset*, since what they
>> now actually do depends on the device type (and it may be something else
>> than doing a hw_reset).
>
> I don't follow your reasoning about the rename.  Cycling the power is
> a kind of hardware reset isn't it.

Since we finalize the reset by calling bus_ops->power_restore, I was
looking for something symmetrical. Ulf mentioned perhaps extending
bus_ops->power_save, but I couldn't find a reasonable way of doing
this. Do you propose simply calling it bus_ops->hw_reset ?

//Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux