On Wednesday 08 October 2014 14:50:46 Ulf Hansson wrote: > On 8 October 2014 14:07, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Thursday 02 October 2014 20:16:44 Ulf Hansson wrote: > >> On 2 October 2014 18:10, Bartlomiej Zolnierkiewicz > >> <b.zolnierkie@xxxxxxxxxxx> wrote: > >> > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc > >> > and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device > >> > tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is > >> > not specified. Fix it. > >> > > >> > Without this patch: > >> > - "mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators" > >> > patch causes a SD card detection to fail > >> > - "mmc: dw_mmc: Support voltage changes" patch causes a boot hang > >> > > >> > This patch fixes both above problems. > >> > > >> > Suggested-by: Doug Anderson <dianders@xxxxxxxxxx> > >> > Cc: Yuvaraj Kumar C D <yuvaraj.cd@xxxxxxxxxxx> > >> > Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > >> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > >> > Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > >> > >> Unless it causes a bunch non-trivial conflicts, I suggest we take this > >> through my mmc tree to not break bisectability. > > > > Have you tried if it conflicts with arm-soc? If not, > > > > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> > > In conflicts, but it's trivial to fix it. > > Since it actually fixes a regression which is inserted from my mmc > tree, I thought it makes sense to take it through here. Anyway, the > decision is yours. > Why does it cause a regression though? Does this mean you are breaking any boot with an old DT file and a new kernel? That would be very bad, the driver is supposed to keep working with an existing dtb. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
