On 11 September 2014 08:38, Grégory Soutadé <gsoutade@xxxxxxxxxxx> wrote:
> Replace ext_csd "enhanced_area_en" attribute by
> "partition_setting_completed". It was used whether or
> not enhanced user area is defined and without checks of
> EXT_CSD_PARTITION_SETTING_COMPLETED bit.
>
> Signed-off-by: Grégory Soutadé <gsoutade@xxxxxxxxxxx>
This patch doesn't compile.
I also think you could work a bit on the commit messages in this
patchset. Try to describe what the patches do and why. I may help you
- if you like.
> ---
> drivers/mmc/core/mmc.c | 9 ++++++++-
> include/linux/mmc/card.h | 2 +-
> include/linux/mmc/mmc.h | 2 ++
> 3 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 77b4cf3..3578e35 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -488,6 +488,13 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
> ext_csd[EXT_CSD_TRIM_MULT];
> card->ext_csd.raw_partition_support = ext_csd[EXT_CSD_PARTITION_SUPPORT];
> if (card->ext_csd.rev >= 4) {
> + if (ext_csd[EXT_CSD_PARTITION_SETTING_COMPLETED] &
> + EXT_CSD_PART_SETTING_COMPLETED) {
No need for brackets if this if-else, please remove.
> + card->ext_csd.partition_setting_completed = 1;
> + } else {
> + card->ext_csd.partition_setting_completed = 0;
> + }
> +
> mmc_manage_enhanced_area(card, ext_csd);
>
> mmc_manage_gp_partitions(card, ext_csd);
[...]
Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
