On 9 September 2014 08:07, Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxx> wrote: > > Hi Ulf > >> > This means we need to copy this ops for each driver ? >> > Otherwise, it breaks behavior if many drivers were probed. >> >> The are only one driver for omap_hsmmc, this is not tmio, which >> certainly is a different story. >> >> What you need to do, is to make omap_hsmmc_ops non const - and assign >> the function pointer here. That should work. > > I meant this case > > omap_hsmmc@0 0xAAAAAA irq = xxxx (MULTI read workaround is needed) > omap_hsmmc@1 0xBBBBBB irq = yyyy (MULTI read workaround is not needed) > > Maybe current omap doesn't have 2 hsmmc on 1 SoC (I don't know) > but, we don't know the future ? > Of course I can follow your style if this issue never happen The above can be handled by having different omap variants structs, like how mmci does it. Also, I don't think we need to worry about that now. So please adopt to my proposal. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
