On 9 September 2014 02:14, Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxx> wrote: > > Hi Ulf > >> > @@ -142,6 +144,8 @@ struct tmio_mmc_data { >> > /* clock management callbacks */ >> > int (*clk_enable)(struct platform_device *pdev, unsigned int *f); >> > void (*clk_disable)(struct platform_device *pdev); >> > + int (*multi_io_quirk)(struct mmc_card *card, >> > + unsigned int direction, int blk_size); >> >> Do you really need to invent new platform callbacks for this? Wouldn't >> it be possible to let the driver handle the quirk by itself? > > sh_mobile_sdhi is based on tmio_mmc_xxx, > and sh_mobile_sdhi side needs this quirk. > I don't know original tmio_mmc_xxx HW. > > Of course we can add new flag to tmio driver, > but, it is same way as before ? You are right, let's keep this patch as is, besides the "#include <linux/blkdev.h>", which isn't needed. Sorry for the noise. Kind regards Uffe > > Best regards > --- > Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html