Re: [PATCH 3/7 v3] mmc: use .multi_io_quirk on tmio_mmc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8 September 2014 13:11, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Mon, 08 Sep 2014, Ulf Hansson wrote:
>
>> On 3 September 2014 04:09, Kuninori Morimoto
>> <kuninori.morimoto.gx@xxxxxxxxx> wrote:
>> > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>> >
>> > Now, tmio_mmc can use .multi_io_quirk callback
>> > instead of MMC_CAP2_NO_MULTI_READ flags.
>> > let's use it.
>> >
>> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>> > ---
>> > v2 -> v3
>> >
>> >  - blk_size_workaround -> multi_io_quirk
>> >
>> >  drivers/mmc/host/tmio_mmc_pio.c |   13 +++++++++++++
>> >  include/linux/mfd/tmio.h        |    4 ++++
>>
>> "mfd"? That was an odd place for storing the tmio mmc specific platform data.
>>
>> So, we need an ack for the mfd maintainer on this one as well. Lee,
>> can you have a look?
>>
>> Future wise, I would also suggest the include/linux/mfd/tmio.h to be
>> split up in proper pieces.
>
> struct tmio_mmc_data looks like it's populated in the MFD driver, thus
> this is probably the correct place for it.

You are right, just that we normally put these in
include/linux/platform_data/* nowadays. Similar applies to struct
tmio_nand_data and struct tmio_fb_data.

Additionally, struct tmio_mmc_dma, could be moved to mmc and may be
forward declared at wherever struct tmio_mmc_data is put.

I also found tmio_core_mmc_enable(), tmio_core_mmc_resume(),
tmio_core_mmc_pwr() and tmio_core_mmc_clk_div() - those could stay in
a local mfd subsystem header file instead of in /include/linux/...

Anyway, I just thought it make sense to clean it up, to possibly
prevent further unnecessary cross subsystem acks. :-)

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux