Re: [PATCH] mmc: tmio: enable odd number size transfer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert

 > +       buf8 = (u8 *)(buf + ((count - 1) >> 1));
> 
> The "-1" is not really needed.

This -1 is needed.

We want to have...
count - offset
1       0
2       0
3       1
4       1
...

> I think it's better to use shifts for both read and write, and add an
> le16_to_cpu()/
> cpu_to_le16() if needed.

I see. will fix in v2


Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux