> -----Original Message----- > From: Ulf Hansson [mailto:ulf.hansson@xxxxxxxxxx] > Sent: Tuesday, September 02, 2014 6:06 PM > To: Gao, Yunpeng > Cc: linux-mmc; Dong, Chuanxiao > Subject: Re: [PATCH] mmc: sdhci-pci: disable preset register for Baytrail and > Merrifield > > On 18 August 2014 09:32, Yunpeng Gao <yunpeng.gao@xxxxxxxxx> wrote: > > Due to HW issue, SDHCI host controller on Intel Baytrail/Merrifield > > platforms can not use preset register. So, disable preset registers > > for them by quirks. > > > > Signed-off-by: Yunpeng Gao <yunpeng.gao@xxxxxxxxx> > > Signed-off-by: Chuanxiao Dong <chuanxiao.dong@xxxxxxxxx> > > Hi Yunpeng, > > Could you please rebase this patch, it didn't apply to my next branch. OK. I'll git clone my mmc_next tree and rebase the patch. And will submit it again once done. Thanks for the review. Thanks. Regards, Yunpeng > Kind regards > Uffe > > > --- > > drivers/mmc/host/sdhci-pci.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mmc/host/sdhci-pci.c > > b/drivers/mmc/host/sdhci-pci.c index 52c42fc..98187ae 100644 > > --- a/drivers/mmc/host/sdhci-pci.c > > +++ b/drivers/mmc/host/sdhci-pci.c > > @@ -277,18 +277,21 @@ static int byt_sdio_probe_slot(struct > > sdhci_pci_slot *slot) } > > > > static const struct sdhci_pci_fixes sdhci_intel_byt_emmc = { > > + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, > > .allow_runtime_pm = true, > > .probe_slot = byt_emmc_probe_slot, > > }; > > > > static const struct sdhci_pci_fixes sdhci_intel_byt_sdio = { > > - .quirks2 = SDHCI_QUIRK2_HOST_OFF_CARD_ON, > > + .quirks2 = SDHCI_QUIRK2_HOST_OFF_CARD_ON | > > + SDHCI_QUIRK2_PRESET_VALUE_BROKEN, > > .allow_runtime_pm = true, > > .probe_slot = byt_sdio_probe_slot, > > }; > > > > static const struct sdhci_pci_fixes sdhci_intel_byt_sd = { > > - .quirks2 = SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON, > > + .quirks2 = SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON | > > + SDHCI_QUIRK2_PRESET_VALUE_BROKEN, > > .allow_runtime_pm = true, > > .own_cd_for_runtime_pm = true, }; @@ -312,7 +315,8 @@ > static > > int intel_mrfl_mmc_probe_slot(struct sdhci_pci_slot *slot) > > > > static const struct sdhci_pci_fixes sdhci_intel_mrfl_mmc = { > > .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC, > > - .quirks2 = SDHCI_QUIRK2_BROKEN_HS200, > > + .quirks2 = SDHCI_QUIRK2_BROKEN_HS200 | > > + SDHCI_QUIRK2_PRESET_VALUE_BROKEN, > > .probe_slot = intel_mrfl_mmc_probe_slot, > > }; > > > > -- > > 1.7.9.5 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > > info at http://vger.kernel.org/majordomo-info.html ��.n��������+%������w��{.n�����{��i��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
