On Mon, Aug 18, 2014 at 8:40 AM, kbuild test robot <fengguang.wu@xxxxxxxxx> wrote: > drivers/mmc/core/slot-gpio.c: In function 'mmc_gpiod_request_cd': >>> drivers/mmc/core/slot-gpio.c:311:57: error: 'GPIOD_IN' undeclared (first use in this function) > desc = devm_gpiod_get_index(host->parent, con_id, idx, GPIOD_IN); > ^ This is because we now require GPIOLIB. I have two ways to solve this: - Make CONFIG_MMC select CONFIG_GPIOLIB - Make slot-gpio optional by introducing stubs in <linux/mmc/slot-gpio.h> if CONFIG_GPIOLIB is not set and not compile slot-gpio.c if GPIOLIB is not selected. Which one would the MMC maintainers prefer? I don't think we have a system using some legacy GPIO API without GPIOLIB so we should enforce this somehow. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
