Re: [PATCH] mmc: au1xmmc: fix error return code in au1xmmc_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14 August 2014 03:00,  <weiyj_lk@xxxxxxx> wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Thanks! Applied for next.

Kind regards
Uffe

> ---
>  drivers/mmc/host/au1xmmc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c
> index 9c9f6af..725f6a6 100644
> --- a/drivers/mmc/host/au1xmmc.c
> +++ b/drivers/mmc/host/au1xmmc.c
> @@ -1028,9 +1028,12 @@ static int au1xmmc_probe(struct platform_device *pdev)
>         host->clk = clk_get(&pdev->dev, ALCHEMY_PERIPH_CLK);
>         if (IS_ERR(host->clk)) {
>                 dev_err(&pdev->dev, "cannot find clock\n");
> +               ret = PTR_ERR(host->clk);
>                 goto out_irq;
>         }
> -       if (clk_prepare_enable(host->clk)) {
> +
> +       ret = clk_prepare_enable(host->clk);
> +       if (ret) {
>                 dev_err(&pdev->dev, "cannot enable clock\n");
>                 goto out_clk;
>         }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux