On 11 August 2014 10:32, <rogerable@xxxxxxxxxxx> wrote: > From: Roger Tseng <rogerable@xxxxxxxxxxx> > > Current code erroneously fill the last byte of R2 response with an undefined > value. In addition, it is impossible to obtain the real values since the > controller actually 'offloads' the last byte(CRC7, end bit) while receiving R2 > response. This could cause mmc stack to obtain inconsistent CID from the same > card after resume and misidentify it as a different card. > > Fix by assigning a dummy value 0x01 to the last byte of R2 response. > > Signed-off-by: Roger Tseng <rogerable@xxxxxxxxxxx> Thanks! Queued for 3.18. I guess this should go for stable as well? Kind regards Uffe > --- > drivers/mmc/host/rtsx_pci_sdmmc.c | 1 + > drivers/mmc/host/rtsx_usb_sdmmc.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c > index dfde4a2..54849d8 100644 > --- a/drivers/mmc/host/rtsx_pci_sdmmc.c > +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c > @@ -412,6 +412,7 @@ static void sd_send_cmd_get_rsp(struct realtek_pci_sdmmc *host, > } > > if (rsp_type == SD_RSP_TYPE_R2) { > + ptr[16] = 1; > for (i = 0; i < 4; i++) { > cmd->resp[i] = get_unaligned_be32(ptr + 1 + i * 4); > dev_dbg(sdmmc_dev(host), "cmd->resp[%d] = 0x%08x\n", > diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c > index 5d3766e..ca08df1 100644 > --- a/drivers/mmc/host/rtsx_usb_sdmmc.c > +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c > @@ -435,6 +435,7 @@ static void sd_send_cmd_get_rsp(struct rtsx_usb_sdmmc *host, > } > > if (rsp_type == SD_RSP_TYPE_R2) { > + ptr[16] = 1; > for (i = 0; i < 4; i++) { > cmd->resp[i] = get_unaligned_be32(ptr + 1 + i * 4); > dev_dbg(sdmmc_dev(host), "cmd->resp[%d] = 0x%08x\n", > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html