Re: [PATCH] mmc: sdhci: fix the wrong type of curr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1 August 2014 08:00, Chuanxiao Dong <chuanxiao.dong@xxxxxxxxx> wrote:
> curr should use signed type since it will contain the returned
> value which is possible to be a negative value. Using u32 will
> make the returned value to be true even there is a negative result.
> Change to use int instead of u32
>
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@xxxxxxxxx>

Thanks! Queued for 3.18.

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 47055f3..c026ec8 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3078,7 +3078,7 @@ int sdhci_add_host(struct sdhci_host *host)
>          */
>         max_current_caps = sdhci_readl(host, SDHCI_MAX_CURRENT);
>         if (!max_current_caps && host->vmmc) {
> -               u32 curr = regulator_get_current_limit(host->vmmc);
> +               int curr = regulator_get_current_limit(host->vmmc);
>                 if (curr > 0) {
>
>                         /* convert to SDHCI_MAX_CURRENT format */
> --
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux