On 12 August 2014 11:29, Sun, Yi Y <yi.y.sun@xxxxxxxxx> wrote:
> Hi, Ulf,
>
> Could you please check this fix? Thanks!
>
> BRs,
> Sun Yi
>
> -----Original Message-----
> From: Sun, Yi Y
> Sent: Friday, August 01, 2014 3:03 PM
> To: linux-mmc@xxxxxxxxxxxxxxx
> Cc: Sun, Yi Y
> Subject: [PATCH] mmc: MMC_NUM_PHY_PARTITION is not right.
>
> eMMC card can support up to 7 partitions, including 2 boot,
> 1 RPMB and 4 GPs. But MMC_NUM_PHY_PARTITION is defined to
> 6 so we should fix it to 7.
>
> Signed-off-by: yisun1 <yi.y.sun@xxxxxxxxx>
Could you please update your name in SOB tag to your proper name.
> ---
> include/linux/mmc/card.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index d424b9d..6dadac2 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -218,7 +218,7 @@ enum mmc_blk_status {
> */
There are a small comment in the code just prior these defines, could
update it so that it becomes obvious why MMC_NUM_PHY_PARTITION shall
be 7.
> #define MMC_NUM_BOOT_PARTITION 2
> #define MMC_NUM_GP_PARTITION 4
> -#define MMC_NUM_PHY_PARTITION 6
> +#define MMC_NUM_PHY_PARTITION 7
> #define MAX_MMC_PART_NAME_LEN 20
>
> /*
> --
> 1.7.9.5
>
I think we should handle this a fix and it should go stable as well.
Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
