On Wed, Jul 16, 2014 at 04:08:11PM -0700, Stephen Boyd wrote: > On 07/16/14 12:38, Stephen Boyd wrote: > > On 07/16/14 11:44, Greg KH wrote: > >> My specific question is why 2 different interfaces? > > Ok. It definitely looks odd to support set/get of the VDD with sysfs and > > ioctl interfaces. I'm just guessing, but I suspect it's a permissions > > thing given that the patch that introduces the VDD stuff also updates > > the permissions of the device node. Of course, the commit text only > > mentions an ioctl, nothing about sysfs. The only other sysfs stuff seems > > to be module parameters to change the vendor ids. > > > > I'll have to go repo diving to figure out if the sysfs interface was > > ever used. Maybe Alex or Konstantin can respond before I have to do that. > > > > > > I couldn't find any usage of the sysfs interface. The only thing I see > used is the host_name field when the module is inserted, if that even > happens at all (I'm not sure because it's behind some ifdef that may or > may not be defined). Sorry this doesn't explain why there are two > different interfaces for the VDD stuff. Hopefully Alex or Konstantin can > help. Thanks for looking. Alex and/or Konstantin, any objection to me removing the sysfs interface on this driver, and just using the char device ioctl hellhole^WAPI instead? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
