Hi Bing, 2014-07-01 8:44 GMT+02:00 Bing Zhao <bzhao@xxxxxxxxxxx>: [snip] >> Yes, a helper might be the best solution. It could even be a generic one, that >> just takes any number of clocks, reset GPIOs and regulators and takes care >> for sequencing them. However, we need to reference that helper from the >> mwifiex driver, for two reasons. >> >> a) we need to make sure the reset helper gets to do its job before the >> mwifiex driver scans the SDIO bus, and >> >> b) the reset helper needs to be called when the mmc host controller wants >> to do a card reset. >> >> Hence, we'll need some sort of internal API for this, and a phandle in dts. I >> wonder whether that glue logic might be better off living in the mmc core, as >> mwifiex might well be interfaced to other hosts? > > I may have missed something, but doesn't the MMC_POWER_OFF and MMC_POWER_ON|UP handling in controller driver help? > Anyway the clocks/GPIOs/regulators are sort of platform dependent. Would it be better putting it in /arch/arm/mach-xxxxx/? what about usb? the mwifiex can also be connected via usb to the host, isn't the reset logic the same in that case, independent of sdio -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html