Seungwon,
On Mon, May 19, 2014 at 6:51 PM, Seungwon Jeon <tgih.jun@xxxxxxxxxxx> wrote:
>> > >> >> + } else {
>> > >> >> + /*
>> > >> >> + * If we don't have a command complete now we'll
>> > >> >> + * never get one since we just reset everything;
>> > >> >> + * better end the request.
>> > >> >> + *
>> > >> >> + * If we do have a command complete we'll fall
>> > >> >> + * through to the SENDING_STOP command and
>> > >> >> + * everything will be peachy keen.
>> > >> >> + *
>> > >> >> + * TODO: I guess we shouldn't send a stop?
>
> Please remove TODO:
OK
> We already reset controller in dw_mci_data_complete() through "mmc: dw_mmc: change to use recommended reset procedure"?
> I guess it depends on that patch.
> Then, we don't need to stop sequence anymore.
Even without that patch we've still pretty much stopped everything in
dw_mci_fifo_reset(), so I'm not sure there's any strong dependency.
...but in our tree this did land after the patch you mention, so you
could wait until it lands if you want.
NOTE: We found that on some machines we were getting warnings after
enabling tuning and using this patch. The warnings were benign, but
we should probably squash the fix into this patch. See
<https://chromium-review.googlesource.com/#/c/200652/> for details.
-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
