On Mon, May 19, 2014 at 9:18 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Monday 19 May 2014 21:03:13 Vasily Khoruzhick wrote: >> Utilise new s3c24xx-dma dmaengine driver for DMA ops. >> >> Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx> Hi Arnd, > Very nice! Thanks! :) > I had done a similar conversion earlier but not tested and only > posted in a reply to another thread. I'd assume that your > version is better and that you have actually tested it, but just > for reference, here is what I had. Maybe it helps you to take > a look at my version to see if there is something you missed. Hm, I did search for s3c24xx-i2s conversion, but didn't for s3cmci, my fault. Your version looks pretty close to mine, however I don't think that much variations are possible here. I've tested mine on s3c2410 machine. > Here are the differences I found: > > - I don't save the 'desc' pointer as you do, but I don't see it used > anywhere. Yeah, I should remove it. Will send v2 shortly. > - I did not remove MMC_S3C_PIODMA, but I don't see anything wrong > with yours there It didn't work even with legacy code for me. I don't want to fix it, so it's just dropped. Anyway, I don't see much sense in PIODMA mode. > - the slave config setup is slightly different Yep. > - I hardcode the DMA request number, while you pass it as a resource. > Actually both are wrong I guess, it should be platform data instead. Well, at least s3c64xx uses resources for passing dma channel number, and so did I. Btw, It'll make transition to device tree a bit easier. There's one more difference: original s3cmci doesn't restore prescaler value when necessary on s3c2410, my version has a fix for it. > Arnd Regards Vasily -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
