H. Peter Anvin wrote: > Seems to me to make the code easier to read, not harder. That was the > whole point. I thought it made it harder by moving the terminating 1 bit out of the driver proper, where it has a symbolic name. Thus someone comparing the driver to the spec has to read another source file to figure out how the driver gets that bit set. As it is, the straight-line code in the driver corresponds very simply with the packet as illustrated in the data sheets. I agree it's really really minor either way, but so is the saving we're going for. Since it's not *clearly* an improvement, I err on the side of not messing with a driver I can't test. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
