On Wed, Apr 16, 2014 at 12:20 AM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > On 15 April 2014 19:09, Tim Kryger <tim.kryger@xxxxxxxxxx> wrote: >> On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: >>> A few times I have suggested to switch to use the >>> mmc_regulator_get_supply() API to simplify and consolidate code. Could >>> you please have a look at that? >> >> This function will solve my problem but it also suggests that SDHCI >> drivers should use the vmmc/vqmmc pointers in the mmc_host struct >> rather than the ones in the sdhci_host struct. >> >> Is this your intent? Do you want to see the regulator pointers in the >> sdhci_host struct removed once all drivers are modified to use the >> mmc_host ones? > > Correct. That will consolidate code! > > Then if sdhci has some special needs for regulators, let's first see > if we can adopt the API to handle it, before we decide to put that > code in sdhci driver. Sounds good. Please forget about this patch and consider the new series instead. https://lkml.org/lkml/2014/4/17/653 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
