On Tue, Apr 1, 2014 at 12:25 PM, Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote: > + reg = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(reg)) { > dev_err(&pdev->dev, "ioremap error.\n"); devm_ioremap_resource() already calls dev_err() for the various error cases, so you can drop this line. > return -ENOMEM; return PTR_ERR(reg); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html