Re: [PATCH RESEND 1/2] mmc: mxcmmc: Convert to devm-* API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mon, 24 Mar 2014 10:29:45 +0100 от Ulf Hansson <ulf.hansson@xxxxxxxxxx>:
> On 22 March 2014 09:52, Alexander Shiyan <shc_work@xxxxxxx> wrote:
> > Replace existing resource handling in the driver with managed
> > device resource, this ensures more consistent error values and
> > simplifies error paths.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> > ---
...
> > +static void mxcmci_init_ocr(struct mxcmci_host *host)
> >  {
> > -       host->vcc = regulator_get(mmc_dev(host->mmc), "vmmc");
> > -
> > +       host->vcc = devm_regulator_get(mmc_dev(host->mmc), "vmmc");
> 
> A semi-related comment to this patch. May I suggest you post a follow
> up patch on top of this one, which convert to use the
> mmc_regulator_get_supply() API.

It's an interesting idea. I'll try to make it a bit later.

---

��.n��������+%������w��{.n�����{��i��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux