On 14.03.2014 11:06, Linus Walleij wrote: > On Mon, Mar 10, 2014 at 2:02 PM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > >> In preparation for adding a descriptor-based CD GPIO >> API, switch from recording GPIO numbers to recording >> GPIO descriptors. >> >> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> > > Certainly this makes things look better from a GPIO POV > so Acked-by. > > However: > > (...) >> + ctx->ro_gpio = gpio_to_desc(gpio); > (...) >> + ctx->cd_gpio = gpio_to_desc(gpio); > > How much harder would it be to switch the platforms using this > MMC driver to pass GPIO descriptors using the gpiod_lookup_table > in affected platforms (or device tree or ACPI) and then use > devm_gpiod_get[_index]() in probe()? There are 10 drivers plus users of mmc_of_config(), so too much work for me right now. Also parts that relate to device-tree are outside my sphere. > This can certainly be step 2, but that is where we want to go with > the GPIO clean-up work in the long run. Perhaps Ulf or Guennadi would be interested. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
