commit 6c31b21 (mmc: omap_hsmmc: remove access to SYSCONFIG register) introduced an smatch(http://smatch.sf.net) warning for the following: drivers/mmc/host/omap_hsmmc.c:608 omap_hsmmc_context_restore() warn: add some parenthesis here? drivers/mmc/host/omap_hsmmc.c:608 omap_hsmmc_context_restore() warn: maybe use && instead of & sparse reports: drivers/mmc/host/omap_hsmmc.c: warning: dubious: !x & y Fix the same. Signed-off-by: Nishanth Menon <nm@xxxxxx> --- drivers/mmc/host/omap_hsmmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index dbd32ad..575f9cc 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -605,7 +605,7 @@ static int omap_hsmmc_context_restore(struct omap_hsmmc_host *host) u32 hctl, capa; unsigned long timeout; - if (!OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE) + if (!(OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE)) return 1; if (host->con == OMAP_HSMMC_READ(host->base, CON) && -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html